Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Generalize warnings for top-level calls to Any or AnyRef methods #20312

Merged
merged 3 commits into from
May 1, 2024
Merged

Generalize warnings for top-level calls to Any or AnyRef methods #20312

merged 3 commits into from
May 1, 2024

Conversation

mbovel
Copy link
Member

@mbovel mbovel commented May 1, 2024 •
edited
Loading

751cc2f is a more direct way to fix #17493 than #20301.

7a9102a further generalizes checkAnyRefMethodCall, as suggested by @odersky.

mbovel and others added 2 commits May 1, 2024 12:02
@mbovel @nox213
Add warning for synchronized calls in value classes
751cc2f 
Co-Authored-By: Yoonjae Jeon <18438185+nox213@users.noreply.github.com>
@mbovel
Generalize checkAnyRefMethodCall
7a9102a
@nox213 nox213 mentioned this pull request May 1, 2024
Closed
@mbovel mbovel requested review from sjrd and odersky May 1, 2024 14:34
sjrd
sjrd approved these changes May 1, 2024
View reviewed changes
tests/warn/i17493.scala Outdated Show resolved Hide resolved
@mbovel @sjrd
Fix indentation
27cc89d 
Co-authored-by: Sébastien Doeraene <sjrdoeraene@gmail.com>
@odersky odersky enabled auto-merge May 1, 2024 15:32
@odersky odersky merged commit 9348ae7 into scala:main May 1, 2024
16 checks passed
@mbovel mbovel deleted the mb/17493-2 branch May 1, 2024 17:28
@Kordyjan Kordyjan added this to the 3.5.0 milestone May 10, 2024
@som-snytt som-snytt mentioned this pull request Jun 21, 2024
Closed
@WojciechMazur WojciechMazur mentioned this pull request Jul 6, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jul 6, 2024
@WojciechMazur
Backport "Generalize warnings for top-level calls to Any or AnyRef me…
80791ef 
…thods" to LTS (#21091)

Backports #20312 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@odersky odersky odersky approved these changes

@sjrd sjrd sjrd approved these changes

Assignees

@odersky odersky

Labels
None yet
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.

Missing error on synchronized from value class
4 participants
@mbovel @sjrd @odersky @Kordyjan