-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Weekly metals backport #20542
Weekly metals backport #20542
Conversation
14cab73
to
a782184
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you take a look at the failure? It seems to fail at dotty.tools.pc.tests.edit.AutoImplementAbstractMembersSuite
It's the same thing as here: scalameta/metals#6482 (comment). The compiler seems to randomly choose ordering here. |
Why did it never pop up before though 🤔 Let's make sure the test is solid before merging, since everyone else would be really unhappy about an additional flaky test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Backports #20542 to the LTS branch. PR submitted by the release tooling. [skip ci]
scalameta/metals#6454
scalameta/metals#6380
scalameta/metals#6479
scalameta/metals#6480
scalameta/metals#6493
scalameta/metals#6496