Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Weekly metals backport #20542

Merged
merged 6 commits into from
Jun 13, 2024
Merged

Weekly metals backport #20542

merged 6 commits into from
Jun 13, 2024

Conversation

kasiaMarek
Copy link
Contributor

@kasiaMarek kasiaMarek commented Jun 10, 2024

@kasiaMarek kasiaMarek requested a review from tgodzik June 10, 2024 13:17
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you take a look at the failure? It seems to fail at dotty.tools.pc.tests.edit.AutoImplementAbstractMembersSuite

@kasiaMarek
Copy link
Contributor Author

Could you take a look at the failure? It seems to fail at dotty.tools.pc.tests.edit.AutoImplementAbstractMembersSuite

It's the same thing as here: scalameta/metals#6482 (comment). The compiler seems to randomly choose ordering here.

@tgodzik
Copy link
Contributor

tgodzik commented Jun 11, 2024

Could you take a look at the failure? It seems to fail at dotty.tools.pc.tests.edit.AutoImplementAbstractMembersSuite

It's the same thing as here: scalameta/metals#6482 (comment). The compiler seems to randomly choose ordering here.

Why did it never pop up before though 🤔 Let's make sure the test is solid before merging, since everyone else would be really unhappy about an additional flaky test

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tgodzik tgodzik merged commit 61a15b2 into scala:main Jun 13, 2024
24 checks passed
@Kordyjan Kordyjan added this to the 3.5.1 milestone Jul 3, 2024
WojciechMazur added a commit that referenced this pull request Jul 10, 2024
Backports #20542 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants