Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Stop auto closing single quotes #274

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

Jentsch
Copy link
Contributor

@Jentsch Jentsch commented Oct 8, 2024

See #255 (comment). Feel free to close this PR if I'm wrong.

Fixes Autoclosing Single Quote in Macro Programming #255

Fixes Autoclosing Single Quote in Macro Programming scala#255
@tgodzik
Copy link
Contributor

tgodzik commented Oct 8, 2024

That is a bit of a conundrum, since want single to autoclose, but ideally after typing a single character 🤔

Though I agree this can be more annoying than helpful

@Jentsch
Copy link
Contributor Author

Jentsch commented Oct 8, 2024

For that we would need some kind of regular expression - something along the lines of ["'[^{]", "'"].
I couldn't find detailed specs for autoclosingpairs, but the implementation in vscode looks like it only supports strings. (But I found the code hard to read, I could be wrong here.) I also just tried, but to no avail.

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge it since really this hasn't been a lot of help as you usually have to go back one character to actually write a character. `` itself is not valid

@tgodzik tgodzik merged commit a6e4fb7 into scala:main Oct 9, 2024
2 checks passed
@Jentsch Jentsch deleted the fix-autoclosing-single-quote branch October 9, 2024 13:01
@Jentsch
Copy link
Contributor Author

Jentsch commented Oct 9, 2024

@tgodzik do we close now #255 or do we wait until the change is published?

@tgodzik
Copy link
Contributor

tgodzik commented Oct 9, 2024

We can close it yeah

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants