Open VariableUtils API #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iusildra
force-pushed
the
open-variable-utils-api
branch
from
8bf35c6 to
58a62db
Compare
adpi2
requested changes
Jun 16, 2023
...rc/main/java/com/microsoft/java/debug/core/adapter/variables/IEvaluateNameUtilsProvider.java
Outdated
Show resolved
Hide resolved
....debug.core/src/main/java/com/microsoft/java/debug/core/adapter/variables/VariableUtils.java
Outdated
Show resolved
Hide resolved
iusildra
force-pushed
the
open-variable-utils-api
branch
from
58a62db to
00887a7
Compare
adpi2
approved these changes
Jun 19, 2023
| @@ -78,6 +79,7 @@ public CompletableFuture<Response> handle(Command command, Arguments arguments, | |||
| boolean showStaticVariables = DebugSettings.getCurrent().showStaticVariables; | |||
|
|
|||
| Map<String, Object> options = variableFormatter.getDefaultOptions(); | |||
| IVariableProvider evaluateNameUtils = context.getProvider(IVariableProvider.class); | |||
There was a problem hiding this comment.
Suggested change
| IVariableProvider evaluateNameUtils = context.getProvider(IVariableProvider.class); | |
| IVariableProvider variableProvider = context.getProvider(IVariableProvider.class); |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pr, we needed to be able to modify the expression of an array element when adding it to watches. It was not possible with the current implementation so I opened it by transforming
VariableUtils(that contains the parsing method) into a provider to use my own implementation for Scala