prevent concurrent modifications of sources by limiting concurrency #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjaglin
force-pushed
the
prevent-concurrent-modifications
branch
from
f429bd9 to
fcfd608
Compare
bjaglin
commented
Jul 16, 2020
| @@ -375,6 +378,9 @@ object ScalafixPlugin extends AutoPlugin { | |||
| } | |||
| } | |||
| } | |||
| task.tag(scalafixTag) | |||
There was a problem hiding this comment.
Suggested change
| task.tag(scalafixTag) | |
| task |
breaks the scripted
[info] [error] (Compile / check) java.lang.AssertionError: assertion failed: missing footer in
[info] [error] <<<// HEADER
[info] [error] object Example
[info] [error] >>>
When rewrite rules are executed, `scalafix` and `scalafixAll` may conflict with other tasks transforming `unmanagedSources`. Since there is no way to identify such tasks given the sbt model, and to be defensive against this scenario, `scalafix` tasks may only run concurrently with other `scalafix` tasks, but not with any other tasks. For explicit invocations, this should not damage throughput, but for complex builds with `scalafixOnCompile := true`, this can have a limited impact during the first compile; after that caching should make it negligible.
bjaglin
force-pushed
the
prevent-concurrent-modifications
branch
from
fcfd608 to
fc56a83
Compare
|
@sjrd I am proposing this to address the concerns you expressed in #140 (comment)
|
olafurpg
approved these changes
Jul 17, 2020
Enjoy your break! I'll also be AFK some random weeks during the next 5 ones. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rewrite rules are executed,
scalafixandscalafixAllmay conflict with other tasks transformingunmanagedSources. Since there is no way to identify such tasks given the sbt model, and to be defensive against this scenario,scalafixtasks may only run concurrently with otherscalafixtasks, but not with any other tasks.For explicit invocations, this should not damage throughput, but for complex builds with
scalafixOnCompile := true, this can have a limited impact during the first compile; after that caching should make it negligible.