don't swallow stack traces on unchecked exception #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjaglin
force-pushed
the
dont-swallow-unchecked
branch
2 times, most recently
from
d726607 to
1865001
Compare
bjaglin
commented
Jun 24, 2022
| @@ -101,7 +101,9 @@ class ScalafixInterface private ( | |||
|
|
|||
| def rulesThatWillRun(): Seq[ScalafixRule] = | |||
| try scalafixArguments.rulesThatWillRun().asScala | |||
| catch { case NonFatal(e) => throw new InvalidArgument(e.getMessage) } | |||
| catch { | |||
| case e: ScalafixException => throw new InvalidArgument(e.getMessage) | |||
There was a problem hiding this comment.
leaving the silencing mapping to an invalid argument for https://github.com/scalacenter/scalafix/blob/f41dec8fc14c8c96b84f563ece3bd895304e8287/scalafix-interfaces/src/main/java/scalafix/interfaces/ScalafixArguments.java#L193-L195
bjaglin
force-pushed
the
dont-swallow-unchecked
branch
from
1865001 to
82187f1
Compare
bjaglin
changed the title
bjaglin
force-pushed
the
dont-swallow-unchecked
branch
from
82187f1 to
4d3533e
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards scalacenter/scalafix#1622