evict cached Scalafix instances under memory pressure #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scalafix instances can be memory-consuming (PrintStream's static 8k BufferedWriter allocations are wasteful and hard to remove for example), so this allow eviction in case of memory pressure. To compensate for the added complexity, the implementation was simplified. * Values are now always updated (even if they haven't changed). This probably does not change much performance-wise, as we are trading throwing an exception (costly) against a SoftReference instanciation and the update in the low-cardinality ConcurrentHashMap. * SAM conversion is used now that sbt 0.13 / Scala 2.11 are no longer supported.
bjaglin
changed the title
bjaglin
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scalafix instances can be memory-consuming (PrintStream's static 8k BufferedWriter allocations are wasteful and hard to remove for example), so this allow eviction in case of memory pressure.
To compensate for the added complexity, the implementation was simplified.