Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

make sure sbt-scalafix is published with JDK8 bytecode #456

Merged
merged 1 commit into from
Jan 11, 2025

Conversation

bjaglin
Copy link
Collaborator

@bjaglin bjaglin commented Jan 11, 2025

Fix regression introduced in #414 (impacting 0.12.1 & 0.13.0)

... actually

"-target:jvm-1.8",
is enough, but better safe than sorry!

https://github.com/coursier/coursier/blob/976dd72/modules/jvm/src/main/scala/coursier/jvm/JavaHome.scala#L178-L179

Current coursier default is adoptium:11, so this protects any potential
regression in case "-target:jvm-1.8" is removed somehow fom the build.
@bjaglin bjaglin changed the title publish sbt-scalafix with JDK8 bytecode @bjaglin make sure sbt-scalafix is published with JDK8 bytecode Jan 11, 2025
@bjaglin bjaglin changed the title @bjaglin make sure sbt-scalafix is published with JDK8 bytecode make sure sbt-scalafix is published with JDK8 bytecode Jan 11, 2025
@bjaglin bjaglin marked this pull request as ready for review January 11, 2025 23:08
@bjaglin bjaglin merged commit 4f7f474 into scalacenter:main Jan 11, 2025
6 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant