Update sbt to 1.6.2 #421
Merged
Update sbt to 1.6.2 #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrf
approved these changes
May 9, 2022
|
@sjrd Could you merge this? |
sjrd
reviewed
May 12, 2022
build.sbt
Outdated
Comment on lines
124
to
125
| crossSbtVersions := List("1.2.8"), | ||
| sbtVersion in pluginCrossBuild := "1.2.8", | ||
| crossSbtVersions := List("1.6.2"), | ||
| sbtVersion in pluginCrossBuild := "1.6.2", |
There was a problem hiding this comment.
Can we get away without this change? That changes the level of support for users of scalajs-bundler.
There was a problem hiding this comment.
Yeah, it seems fine. Rolled back.
sjrd
approved these changes
May 12, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes tests and sets up Node and yarn in specific versions for CI, hopefully that is a quick fix to make tests less brittle.