bugfix: Don't show unhelpful renames in hover

scalameta · Feb 29, 2024 · 8ac1f70 · 8ac1f70
1 parent 4903c4f
commit 8ac1f70
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 2 deletions.
diff --git a/mtags/src/main/scala-2/scala/meta/internal/pc/Signatures.scala b/mtags/src/main/scala-2/scala/meta/internal/pc/Signatures.scala
@@ -119,7 +119,9 @@ trait Signatures { compiler: MetalsGlobal =>
       }
 
     def getUsedRenames: Map[Symbol, String] = lookedUpRenames.flatMap { key =>
-      renames.get(key).map(v => key -> v.toString())
+      renames.get(key).collect {
+        case v if key.nameString != v.toString => key -> v.toString()
+      }
     }.toMap
 
     def this(context: Context) =

diff --git a/mtags/src/main/scala-3/scala/meta/internal/pc/printer/ShortenedNames.scala b/mtags/src/main/scala-3/scala/meta/internal/pc/printer/ShortenedNames.scala
@@ -36,7 +36,8 @@ class ShortenedNames(
       s"type $to = ${from.showName}"
     }.toList
 
-  def getUsedRenames: Map[Symbol, String] = foundRenames.toMap
+  def getUsedRenames(using Context): Map[Symbol, String] =
+    foundRenames.toMap.filter { case (k, v) => k.showName != v }
 
   /**
    * Returns a list of shortened names

diff --git a/tests/cross/src/test/scala/tests/hover/HoverTermSuite.scala b/tests/cross/src/test/scala/tests/hover/HoverTermSuite.scala
@@ -680,4 +680,24 @@ class HoverTermSuite extends BaseHoverSuite {
     )
   )
 
+  check(
+    "import-no-rename",
+    """
+      |import scala.collection
+      |
+      |object O {
+      |  <<val ab@@c = collection.Map(1 -> 2)>>
+      |}
+      |""".stripMargin,
+    """|```scala
+       |val abc: collection.Map[Int,Int]
+       |```
+       |""".stripMargin,
+    compat = Map(
+      "3" -> """|```scala
+                |val abc: scala.collection.Map[Int, Int]
+                |```
+                |""".stripMargin
+    )
+  )
 }