Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

doc: add a few tips on converting from match-style assertions #164

Merged
merged 1 commit into from
Jul 17, 2020

Conversation

Kazark
Copy link
Contributor

@Kazark Kazark commented Jul 16, 2020

With this in place, I think MUnit's documentation captures everything I learned during the conversion. I wonder, though, whether it would be worthwhile to make this page a little more self-contained, i.e. what about linking back to other parts of the documentation that are relevant? Part of the reason I say this is because when a teammate of mine original saw this page, he remarked that it was rather sparse. Perhaps it would be nice to be able to have people go straight to a page on converting, and from there be guided to the other parts of the documentation that they should read. If folks like this idea, I can submit another PR against this page with links to other part of the documentation that I found especially necessary during the conversion.

Copy link
Member

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it’s a great idea to make the scalatest migration page more self contained! I agree the current page is quite sparse. Thank you 🙏

@olafurpg olafurpg merged commit 43dd22e into scalameta:master Jul 17, 2020
@Kazark Kazark deleted the match-style branch July 17, 2020 13:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants