Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support ScalaTest 3.1+ in PantsFramework #176

Merged
merged 1 commit into from
Aug 11, 2020

Conversation

Duhemm
Copy link
Contributor

@Duhemm Duhemm commented Aug 11, 2020

Previously, MUnit's PantsFramework would look for ScalaTest's JUnit
runner only in org.scalatest.junit.JUnitRunner. In ScalaTest 3.1+,
this class has been moved to org.scalatestplus.junit.JUnitRunner.

This commit adds a new Fingerprint to the PantsFramework, so that
tests defined with ScalaTest 3.1+ can be detected.

Previously, MUnit's `PantsFramework` would look for ScalaTest's JUnit
runner only in `org.scalatest.junit.JUnitRunner`. In ScalaTest 3.1+,
this class has been moved to `org.scalatestplus.junit.JUnitRunner`.

This commit adds a new Fingerprint to the `PantsFramework`, so that
tests defined with ScalaTest 3.1+ can be detected.
@Duhemm Duhemm requested a review from olafurpg August 11, 2020 08:54
Copy link
Member

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thank you!

@olafurpg olafurpg merged commit 1330dda into scalameta:master Aug 11, 2020
@Duhemm Duhemm deleted the scalatestplus-junit branch August 11, 2020 09:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants