Fix bug where test cases got reported as duplicates in IntelliJ. #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes scalameta#47. Previously, the `getDescription` method performed side-effects adding all the test cases as children to the suite description. When a client such as IntelliJ called `getDescription` repeated times then it appeared as if the same test started multiple times in the IntelliJ UI.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47. Previously, the
getDescriptionmethod performedside-effects adding all the test cases as children to the suite
description. When a client such as IntelliJ called
getDescriptionrepeated times then it appeared as if the same test started multiple
times in the IntelliJ UI.