Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Resource folder path resolution from classloader #1692

Merged
merged 1 commit into from
Feb 9, 2020

Conversation

poslegm
Copy link
Collaborator

@poslegm poslegm commented Feb 9, 2020

I think it's more reliable way to get resources. Should fix issue #1681 (comment)

@poslegm poslegm mentioned this pull request Feb 9, 2020
@poslegm poslegm requested review from olafurpg and kitbellew February 9, 2020 20:44
Copy link
Collaborator

@kitbellew kitbellew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i checked it out and ran. unlike before, intellij ran tests. however, i am not sure if this behaviour is as before, as it stopped after 1270 tests, while there are supposed to be 3810 of them.

so while this change is good, perhaps @olafurpg is right and we should take another look at munit integration with scalafmt.

Screen Shot 2020-02-09 at 13 10 12

@poslegm poslegm merged commit d3b77da into master Feb 9, 2020
@poslegm poslegm deleted the resource-resolution branch February 9, 2020 21:49
@poslegm
Copy link
Collaborator Author

poslegm commented Feb 9, 2020

It's correct behaviour, because there is 1270 format tests. IDEA renders it wrong: scalameta/munit#47

Ok, we can revert MUnit migration if it interferes with work on scalafmt. IDEA issues looks confusing.

@kitbellew
Copy link
Collaborator

@poslegm if the issue is simply that intellij renders it wrong, i don't care. just wanted to be sure it runs all tests, so that my continued messing with the codebase doesn't introduce bugs accidentally. :)

@olafurpg
Copy link
Member

I don’t want the MUnit migration to regress the experience of testing via IntelliJ so please feel free to revert back to ScalaTest. Since MUnit is just a JUnit runner I think the IntelliJ testing UX can be amazingly good but it’s not there yet.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants