Don't fail test workflow on release #2088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests need all tags to be fetched but latest tag already pushed to master on release. For this reason git fetch fails on workflows started with git push --tags
kitbellew
reviewed
Jul 12, 2020
| @@ -19,7 +19,7 @@ jobs: | |||
| - uses: olafurpg/setup-scala@v7 | |||
| with: | |||
| java-version: ${{ matrix.java }} | |||
| - run: git fetch --tags | |||
There was a problem hiding this comment.
does it always complain, or only when the tag points to a different sha1?
There was a problem hiding this comment.
I couldn't find the exact cause. It works well on fork's CI, but fails in the main repo. Perhaps it related to merged commits from forks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests need all tags to be fetched but latest tag already pushed to master on release. For this reason git fetch fails on workflows started with git push --tags
Other jobs works correct already.