Router: for scala3, move NL before macro to after #3199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitbellew
commented
Apr 30, 2022
| @@ -2599,6 +2599,13 @@ class Router(formatOps: FormatOps) { | |||
| case ft @ FormatToken(_: T.Comment, _, _) if ft.hasBreak => | |||
| splitsAsNewlines(splits) | |||
| case ft if ft.meta.formatOff && ft.hasBreak => splitsAsNewlines(splits) | |||
| case FormatToken(_: T.Equals, r: T.KwMacro, _) | |||
| if dialect.allowInlineMods => | |||
There was a problem hiding this comment.
@tgodzik not sure if this is the right way to identify scala 3, perhaps as good as any
There was a problem hiding this comment.
I would use allowSignificantIndentation, because it's the cause of the issue. Without significant indentation there would be no issues
tgodzik
approved these changes
Apr 30, 2022
| @@ -2599,6 +2599,13 @@ class Router(formatOps: FormatOps) { | |||
| case ft @ FormatToken(_: T.Comment, _, _) if ft.hasBreak => | |||
| splitsAsNewlines(splits) | |||
| case ft if ft.meta.formatOff && ft.hasBreak => splitsAsNewlines(splits) | |||
| case FormatToken(_: T.Equals, r: T.KwMacro, _) | |||
| if dialect.allowInlineMods => | |||
There was a problem hiding this comment.
I would use allowSignificantIndentation, because it's the cause of the issue. Without significant indentation there would be no issues
Done. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3188.