Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

PolicyOps: unindent correctly in binpacking #3351

Merged
merged 2 commits into from
Oct 25, 2022
Merged

Conversation

kitbellew
Copy link
Collaborator

@kitbellew kitbellew commented Oct 24, 2022

Apply it only if there are no breaks before start of exclude range.

Apply it only if there are no breaks before start of exclude range.
@kitbellew
Copy link
Collaborator Author

@mdedetrich fixes inconsistent indentation shown here: https://github.com/mdedetrich/akka-apache/compare/a42307861c9e37a604243435c321680dba9d33d9..95aec89cd3ae00e55a053cd38fb3efe3e34239a0#diff-4d5075641c71bbb5c06c066e2c568cad848505c358e7867a0f52bb96fb943c29

the fix is not to reduce the indentation of Behaviours but not to reduce the indentation of the subsequent block.

@mdedetrich
Copy link
Contributor

Thanks for looking into this!

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants