Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[PoC] Extract convert import wildcard to start as independent rewrite #3732

Closed
wants to merge 1 commit into from

Conversation

kaatzee
Copy link

@kaatzee kaatzee commented Dec 23, 2023

I would like to know if such change has a chance to be added.
The scenario in which such functionality is needed is when I want to rewrite underscores in imports to stars, but leave possibility to use both old and new syntax for if control syntax.
Currently when I set:

  • rewrite.scala3.convertToNewSyntax = true and allowStarWildcardImport = true and allowSignificantIndentation = true all old if syntax is rewritten to new one
  • rewrite.scala3.convertToNewSyntax = true and allowStarWildcardImport = true and allowSignificantIndentation = false it fails on places where new syntax of if is used.

Let me know what do you think and what further changes are needed to add this functionality.

@kitbellew
Copy link
Collaborator

@kaatzee what's the reason for this requirement? are import underscores deprecated whereas "old" if syntax is not?

@kaatzee
Copy link
Author

kaatzee commented Dec 24, 2023

@kitbellew yes, exactly. I have seen your PR which addresses this approach. Thank you! I am closing this PR then.

@kaatzee kaatzee closed this Dec 24, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants