Add *.py files to model weights if trust_remote_code is provided #635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmchoiboi
requested review from
seanshi-scale and
yunfeng-scale
and removed request for
seanshi-scale
dmchoiboi
force-pushed
the
dmchoi/trust_remote_code
branch
from
924bd8f to
eb5f813
Compare
| framework_image_tag, | ||
| checkpoint_path, | ||
| final_weights_folder, | ||
| trust_remote_code, | ||
| ) | ||
| elif checkpoint_path.startswith("azure://") or "blob.core.windows.net" in checkpoint_path: | ||
| return self.load_model_weights_sub_commands_abs( |
There was a problem hiding this comment.
should we update this too to keep things in sync?
seanshi-scale
approved these changes
Oct 14, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Deepseek loads model configs + tokenizers through python files defined in checkpoint.
What is this PR changing? Why is this change being made? Any caveats you'd like to highlight? Link any relevant documents, links, or screenshots here if applicable.
Test Plan and Usage Guide
How did you validate that your PR works correctly? How do you run or demo the code? Provide enough detail so a reviewer can reasonably reproduce the testing procedure. Paste example command line invocations if applicable.