Skip to content

Updates to get tool use working #638

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Updates to get tool use working #638

merged 1 commit into from
Oct 16, 2024

Conversation

dmchoiboi
Copy link
Collaborator

@dmchoiboi dmchoiboi commented Oct 15, 2024

  • Update oai spec to remove strict flag default to workaround vllm incompatibilty
  • additional flags to set through API
  • fix handling vllm args false flags

Pull Request Summary

What is this PR changing? Why is this change being made? Any caveats you'd like to highlight? Link any relevant documents, links, or screenshots here if applicable.

Test Plan and Usage Guide

Created llama-3-1-8b-instruct endpoint

How did you validate that your PR works correctly? How do you run or demo the code? Provide enough detail so a reviewer can reasonably reproduce the testing procedure. Paste example command line invocations if applicable.

…mpatibilty + additional flags to set through API
@@ -69,6 +69,16 @@ class VLLMModelConfig(BaseModel):
description="A Jinja template to use for this endpoint. If not provided, will use the chat template from the checkpoint",
)

tool_call_parser: Optional[str] = Field(
None,
description="Tool call parser",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's tool call parser?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmchoiboi dmchoiboi merged commit ff971ea into main Oct 16, 2024
7 checks passed
@dmchoiboi dmchoiboi deleted the dmchoi/tool-use-fixes branch October 16, 2024 00:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants