Skip to content

Remove ENV requirement for db migration #654

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Remove ENV requirement for db migration #654

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions model-engine/model_engine_server/db/migrations/alembic/env.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@
from sqlalchemy import engine_from_config, pool

env = os.environ.get("ENV")
if env is None:
assert (
os.getenv("ML_INFRA_DATABASE_URL") is not None
), "Expected ML_INFRA_DATABASE_URL to be set if ENV is not set."
# if env is None:
# assert (
# os.getenv("ML_INFRA_DATABASE_URL") is not None
# ), "Expected ML_INFRA_DATABASE_URL to be set if ENV is not set."

# this is the Alembic Config object, which provides
# access to the values within the .ini file in use.
Expand Down