feat(instance): use sbs images from marketplace on server create #4466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some cassettes still need an update, will first fix server update with sbs volumes
Codelax
force-pushed
the
feat/instance-default-image-sbs
branch
from
be6d85e to
ac92ac5
Compare
Codelax
force-pushed
the
feat/instance-default-image-sbs
branch
from
d1f981d to
b2871e1
Compare
github-actions
bot
added
the
load-balancer
github-actions
bot
added
the
vpc
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4466 +/- ##
==========================================
- Coverage 75.45% 69.28% -6.17%
==========================================
Files 202 300 +98
Lines 44323 67775 +23452
==========================================
+ Hits 33444 46961 +13517
- Misses 9653 19163 +9510
- Partials 1226 1651 +425 ☔ View full report in Codecov by Sentry. |
remyleone
approved these changes
Feb 4, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newly created server should now be using sbs volumes (ex:
scw instance server create type=PLAY2-PICO).While updating tests, I encountered an issue with
scw instance server update, using a SBS volume will create an invalid request.