Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor(Table): implement all new behaviors #4273

Merged
merged 3 commits into from
Oct 2, 2024
Merged

Conversation

matthprost
Copy link
Collaborator

Summary

Type

  • Refactor

Summarise concisely:

What is expected?


"@ultraviolet/ui": minor

Refactoring on <Table />:

  • Update of sort icons
  • Added expandable on <Table /> and <Table.Row />
  • Refactoring of grid system
  • Added align and sentiment prop on <Table.Cell />

Refactoring on <List />:

  • Update of sort icons

"@ultraviolet/icons": patch

Fix sort system icon to follow correct view box

Relevant logs and/or screenshots

Screen.Recording.2024-09-24.at.16.19.06.mov
Screen.Recording.2024-09-24.at.16.31.08.mov
Screenshot 2024-09-24 at 16 18 55 Screenshot 2024-09-24 at 16 21 52 Screenshot 2024-09-24 at 16 29 53

@matthprost matthprost self-assigned this Sep 24, 2024
Copy link

changeset-bot bot commented Sep 24, 2024

🦋 Changeset detected

Latest commit: cdb280b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@ultraviolet/icons Patch
@ultraviolet/ui Minor
@ultraviolet/plus Patch
@ultraviolet/form Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@matthprost matthprost requested review from PetmePant, lisalupi, mhervouet, a team and DorianMaliszewski and removed request for a team September 24, 2024 14:31
@matthprost matthprost added the refactor Refactor without breaking changes label Sep 24, 2024
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 69.14894% with 29 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@84f639e). Learn more about missing BASE report.
Report is 35 commits behind head on main.

Files with missing lines Patch % Lines
packages/ui/src/components/Table/Row.tsx 40.62% 19 Missing ⚠️
packages/ui/src/components/Table/TableContext.tsx 28.57% 10 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4273   +/-   ##
=======================================
  Coverage        ?   86.84%           
=======================================
  Files           ?      316           
  Lines           ?    11527           
  Branches        ?     3182           
=======================================
  Hits            ?    10011           
  Misses          ?     1516           
  Partials        ?        0           
Files with missing lines Coverage Δ
packages/ui/src/components/List/HeaderCell.tsx 97.29% <100.00%> (ø)
packages/ui/src/components/Table/Cell.tsx 100.00% <100.00%> (ø)
packages/ui/src/components/Table/HeaderCell.tsx 97.61% <100.00%> (ø)
packages/ui/src/components/Table/HeaderRow.tsx 100.00% <100.00%> (ø)
packages/ui/src/components/Table/constants.ts 100.00% <100.00%> (ø)
packages/ui/src/components/Table/index.tsx 100.00% <100.00%> (ø)
packages/ui/src/components/Table/TableContext.tsx 82.14% <28.57%> (ø)
packages/ui/src/components/Table/Row.tsx 65.45% <40.62%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84f639e...cdb280b. Read the comment docs.

@matthprost matthprost merged commit 04e9273 into main Oct 2, 2024
11 checks passed
@matthprost matthprost deleted the refactor/table branch October 2, 2024 09:28
@scaleway-bot scaleway-bot mentioned this pull request Oct 2, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
refactor Refactor without breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants