Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add more jasync parameters to config #281

Merged
merged 4 commits into from
Jan 11, 2023
Merged

Add more jasync parameters to config #281

merged 4 commits into from
Jan 11, 2023

Conversation

sbmpost
Copy link
Contributor

@sbmpost sbmpost commented Apr 5, 2022

No description provided.

@sbmpost sbmpost requested review from seratch and xuwei-k as code owners April 5, 2022 10:44
@sbmpost sbmpost mentioned this pull request Apr 5, 2022
Closed
seratch
seratch approved these changes Dec 26, 2022
View reviewed changes
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for our belated response here. This enhancement looks fine. If this project migrates to a different library in the future, these options can be unsupported. That being said, adding these options to this library now should be valuable for many devs.

@sbmpost
Copy link
Contributor Author

sbmpost commented Jan 11, 2023

@seratch I double checked the changes. I think this is good to go now? I can't merge this myself as I am not a contributer.

@seratch seratch merged commit 2ad6b25 into scalikejdbc:master Jan 11, 2023
@seratch
Copy link
Member

seratch commented Jan 11, 2023

Thanks for your contribution! Will release a new version shortly

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@seratch seratch seratch approved these changes

@xuwei-k xuwei-k Awaiting requested review from xuwei-k xuwei-k is a code owner

Assignees
No one assigned
Labels
enhancement
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbmpost @seratch