Improve JDBC Url parsing

[jtjeferreira]

fixes #365

[seratch]

Thanks a lot for promptly updating the PR! This PR already looks great to me but I'd like to wait for others' feedback for a few more days. After that, we can release a new version including this change.

[jtjeferreira]

this field is no longer used, but I didnt remove it due to backwards compatibility. If that is not an issue I can remove it

[seratch]

Thanks, can you add @deprecated annotation to the public field? The since version will be 0.16.0

[jtjeferreira]

Thanks a lot for promptly updating the PR! This PR already looks great to me but I'd like to wait for others' feedback for a few more days. After that, we can release a new version including this change.

ok I can wait since I have an workaround. Nevertheless I used publishLocal and tested the changes in my project successfully.

Another question: should we fix scalikejdbc.JDBCUrl.apply? Or deprecate it so we can remove it in the future?

[jtjeferreira]

Also do you think the code here can now be simplified?

scalikejdbc-async/core/src/main/scala/scalikejdbc/async/AsyncConnectionPoolFactory.scala

Lines 48 to 75 in fc21685

	url match {
	case _ if url.startsWith("jdbc:postgresql://") =>
	new PostgreSQLConnectionPoolImpl(url, user, password, settings)
	case _ if url.startsWith("jdbc:mysql://") =>
	new MySQLConnectionPoolImpl(url, user, password, settings)
	case HerokuPostgresRegexp(_user, _password, _host, _dbname) =>
	// Heroku PostgreSQL
	val _url = "jdbc:postgresql://%s/%s".format(_host, _dbname)
	new PostgreSQLConnectionPoolImpl(_url, _user, _password, settings)
	case HerokuMySQLRegexp(_user, _password, _host, _dbname) =>
	// Heroku MySQL
	// issue #5 Error: database name is too long
	// val defaultProperties = """?useUnicode=yes&characterEncoding=UTF-8&connectionCollation=utf8_general_ci"""
	val defaultProperties = ""
	val addDefaultPropertiesIfNeeded = MysqlCustomProperties
	.findFirstMatchIn(url)
	.map(_ => "")
	.getOrElse(defaultProperties)
	val _url = "jdbc:mysql://%s/%s".format(
	_host,
	_dbname + addDefaultPropertiesIfNeeded
	)
	new MySQLConnectionPoolImpl(_url, _user, _password, settings)

[seratch]

Another question: should we fix scalikejdbc.JDBCUrl.apply? Or deprecate it so we can remove it in the future?

It can still be useful for some simple use cases, so I don't think it should be deprecated immediately. But I agree that the implementation should be complete in the future. I will create a new issue on the project side.

UPDATE: Here is the issue scalikejdbc/scalikejdbc#1825

[seratch]

Also do you think the code here can now be simplified?

No rush but simplifying the code is great!