Updated resolver after slider module update #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denisprotassoff
changed the title
tarasovd
reviewed
Dec 23, 2022
Comment on lines
+97
to
119
| if ($slide->getFirstMobileImageLocation()) { | ||
| $slideData[$slide::FIRST_MOBILE_IMAGE] = $slide->getFirstMobileImageUrl(); | ||
| } | ||
|
|
||
| if ($slide->getFirstDesktopImageLocation()) { | ||
| $slideData[$slide::FIRST_DESKTOP_IMAGE] = $slide->getFirstDesktopImageUrl(); | ||
| } | ||
|
|
||
| if ($slide->getSecondMobileImageLocation()) { | ||
| $slideData[$slide::SECOND_MOBILE_IMAGE] = $slide->getSecondMobileImageUrl(); | ||
| } | ||
|
|
||
| if ($slide->getSecondDesktopImageLocation()) { | ||
| $slideData[$slide::SECOND_DESKTOP_IMAGE] = $slide->getSecondDesktopImageUrl(); | ||
| } | ||
|
|
||
| if ($slide->getThirdMobileImageLocation()) { | ||
| $slideData[$slide::THIRD_MOBILE_IMAGE] = $slide->getThirdMobileImageUrl(); | ||
| } | ||
| unset ($slide); | ||
|
|
||
| if ($sliderData) { | ||
| $result = function () use ($sliderData) { | ||
| return $sliderData; | ||
| }; | ||
| if ($slide->getThirdDesktopImageLocation()) { | ||
| $slideData[$slide::THIRD_DESKTOP_IMAGE] = $slide->getThirdDesktopImageUrl(); | ||
| } |
There was a problem hiding this comment.
Why is this needed?
I guess if there is no image we should get null in response and can handle that on FE.
Isn't it?
There was a problem hiding this comment.
I don't know how it works on FE, so I didn't change any logic here for compatibility.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates slider-graphql module as per this request.
In this PR: