Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update scala-compiler, scala-reflect to 2.12.13 #487

Conversation

scala-steward
Copy link
Contributor

Updates

from 2.12.11 to 2.12.13.

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Files still referring to the old version number

The following files still refer to the old version number (2.12.11).
You might want to review and update them manually.

.github/workflows/pr-checks.yml
README.md
Ignore future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scala-lang" } ]

labels: library-update, semver-patch, old-version-remains

@mccartney
Copy link
Collaborator

@scala-steward We already have 2.12.13 in the list (same list you are actually editing). We need to (or choose to) publish for multiple Scala minor versions at a time.

@mccartney mccartney closed this Feb 28, 2021
@scala-steward scala-steward deleted the update/scala-compiler-2.12.13 branch February 28, 2021 09:50
@fthomas
Copy link

fthomas commented Mar 4, 2021

I think Scala Steward will never do the right thing here. If there is a 2.12.14 version, it will create a PR that changes 2.12.13 to 2.12.14 instead of appending 2.12.14 to the list.

@mccartney
Copy link
Collaborator

Most likely. A minor improvement could be not to suggest upgrading to 2.12.13 if it's already on the list (regardless of what other entry it's changing).
I appreciate your comments and insights!

@fthomas
Copy link

fthomas commented Mar 4, 2021

It won't do this again: scala-steward-org/scala-steward#129

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants