-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Support .config
and environment variable for session
#8
Comments
The |
That's a great idea, please feel free to submit a PR. We could have config_dir as default and if not found revert to home dir. Not so sure about the env var as that could be a little confusing for users (which one takes precedence?) and possibly less safe (if exported as clear text), but happy to consider it too. I'd suggest two separate PRs to make it easier to review. |
The environment variable was actually meant to enable one to use tools that support storing env variables on the keychain. |
That's a good point! My comment about it being less safe was about users doing |
To extend on what OP requests, I'd suggest fully following XDG specification instead of hardcoding support for |
already did so |
For config dir, you could use: https://docs.rs/dirs/4.0.0/dirs/fn.config_dir.html
And for environment variable, I'd imagine something like
ADVENT_OF_CODE_SESSION
.I'd be willing to implement this my self.
The text was updated successfully, but these errors were encountered: