Skip to content

Resolve conflict between lincuan:patch-1 and sccn:develop in OctaveWrapper #4

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Resolve conflict between lincuan:patch-1 and sccn:develop in OctaveWrapper #4

wants to merge 1 commit into from

Conversation

lincuan
Copy link

@lincuan lincuan commented Mar 20, 2025

  • Adopted the eval approach from develop to ensure compatibility with Octave, as direct method calls may fail due to unsupported struct array returns.
  • Added file synchronization (flush and fsync) to address the timing issue noted in patch-1, ensuring pop_saveset completes writing before pop_loadset is called.
  • Set delete=True for temporary files to ensure automatic cleanup, avoiding file accumulation.
  • Retained TODO and explanatory comments for future reference.

@lincuan
Resolve conflict between lincuan:patch-1 and sccn:develop in OctaveWr…
2e2a2c4 
…apper

- Adopted the eval approach from develop to ensure compatibility with Octave, as direct method calls may fail due to unsupported struct array returns.
- Added file synchronization (flush and fsync) to address the timing issue noted in patch-1, ensuring pop_saveset completes writing before pop_loadset is called.
- Set delete=True for temporary files to ensure automatic cleanup, avoiding file accumulation.
- Retained TODO and explanatory comments for future reference.
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lincuan