Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Bug] URL not clickable #258

Closed
ueen opened this issue Jan 31, 2024 · 3 comments · Fixed by #259
Closed

[Bug] URL not clickable #258

ueen opened this issue Jan 31, 2024 · 3 comments · Fixed by #259
Assignees
@schlagmichdoch
Labels
bug Something isn't working

Comments

@ueen
Copy link

ueen commented Jan 31, 2024

send https://m.youtube.com/watch?v=xxxx and its not clickable after receiving
@ueen ueen added the bug Something isn't working label Jan 31, 2024
@schlagmichdoch
Copy link
Owner

schlagmichdoch commented Jan 31, 2024 •
edited
Loading

Here we go again.. The problem seems to be the subdomain with a length of one (m.youtube.com)

I think I will loosen the REGEX. GitHub marks a lot of things as a URLs and let's the clients browser decide if the URL is valid or not.

To test this I'll add your link to the test group:

www.test
www.test.com
https://test.com
http://test.com
https://test.com?auth=token&si=123
https://onedrive.live.com/?authkey=%dfdsssdf7LJSM3w&id=88ADFF5%21285&cid=2DC78C46388A4354
https://m.youtube.com/watch?v=xxxx
https://theländ.de/

schlagmichdoch added a commit that referenced this issue Jan 31, 2024
@schlagmichdoch
Fix URL not replaced with link node (fixes #258), beautify text via r…
d37ebfc 
…egex without rendering it, and fix execution order
@schlagmichdoch
Copy link
Owner

Please test whether everything works as expected: https://pairdrop-dev.onrender.com/

schlagmichdoch added a commit that referenced this issue Feb 1, 2024
@schlagmichdoch
Fix URL not replaced with link node (fixes #258), beautify text via r…
99b0c6f 
…egex without rendering it, and fix execution order
@schlagmichdoch schlagmichdoch mentioned this issue Feb 1, 2024
Merged
5 tasks
@schlagmichdoch schlagmichdoch self-assigned this Feb 1, 2024
@schlagmichdoch
Copy link
Owner

I have tested the dev instance on a lot of devices and it seems to work just fine. I’ll merge it later

schlagmichdoch added a commit that referenced this issue Feb 9, 2024
@schlagmichdoch
Increase version to v1.10.7
d6287c4 
## Enhancements
- Implemented drag and drop into text fields
- Tidy up code
- Translations update from Hosted Weblate (Italian)

## Fixes
- Received URLs with single letter subdomains not hydrated into links #258
- Button does not change color on hover (#262 + #263)
- On Windows Edge, PeerUI shows „preparing“ when file selector is cancelled (#257)
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@schlagmichdoch schlagmichdoch

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release next patch version 1.10.7 schlagmichdoch/PairDrop
2 participants
@ueen @schlagmichdoch