Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove bar at top of screen on iOS #376

Merged

Conversation

realchrislovett
Copy link
Contributor

On iOS, when the app runs as a PWA without this line, there will be a blue bar at the top of the screen. Implementing this setting will make for a more seamless UI on iOS, as documented below.

https://developer.apple.com/library/archive/documentation/AppleApplications/Reference/SafariHTMLRef/Articles/MetaTags.html

Before apple-mobile-web-app-status-bar-style:
Without Commit_DarkWithout Commit_Light

After apple-mobile-web-app-status-bar-style:
With Commit_Dark With Commit_Light

On iOS, when the app runs as a PWA without this line, there will be a bar at the top of the screen. Implementing this setting will make for a more seamless UI on iOS, as documented below.

https://developer.apple.com/library/archive/documentation/AppleApplications/Reference/SafariHTMLRef/Articles/MetaTags.html
@schlagmichdoch
Copy link
Owner

Do you not like the theme color in the header bar?

Also, are these sceenshots from your own tests or from the current state at https://pairdrop.onrender.com/manifest.json ? I'm wondering about the footer being overlayed by the iOS UI

@realchrislovett
Copy link
Contributor Author

The theme color is fine, as it goes along with the other blues. I prefer the fullscreen feel without header bar, however. Makes a lot more sense if you're looking at it on-device, rather than a screenshot.

These where taken on my setup with the changes implemented in the pwa_standalone branch included. I've noticed this overlay as well, but I don't have the expertise to fix it. I assume some sort of padding at the bottom would resolve it. This occurs with or without my commit and seems to just be how the page fills the screen when in "standalone" mode.

@schlagmichdoch
Copy link
Owner

The theme color is fine, as it goes along with the other blues. I prefer the fullscreen feel without header bar, however. Makes a lot more sense if you're looking at it on-device, rather than a screenshot.

I’ll give it a try, thanks!

I assume some sort of padding at the bottom would resolve it. This occurs with or without my commit and seems to just be how the page fills the screen when in "standalone" mode.

This what this css part is for:

https://github.com/schlagmichdoch/PairDrop/blob/8a833cd69dae86519d60b11ee5e094f232772c31/public/styles/styles-main.css#L912-917

Are you completely sure this includes this change? Have you deleted your cache? Please test again on https://pairdrop.onrender.com/ as this is what it looks like for me:

@realchrislovett
Copy link
Contributor Author

Resolved an issue on my side. You are correct. This is a rendering from Xcode's simulator. Also confirmed on my iPhone 16.

Simulator Screenshot - iPhone 16 - 2025-02-14 at 16 25 39

@schlagmichdoch
Copy link
Owner

Perfect! Thanks for testing!

@schlagmichdoch schlagmichdoch merged commit 1d0d3d0 into schlagmichdoch:pwa_standalone Feb 14, 2025
1 check passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants