Fix DoctrineDriverTest random failures #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failed when Travis checked #154 |
|
Rebased on latest master so test pass |
| @@ -92,6 +92,9 @@ public function testNonDoctrineEntityClassIsNotModified() | |||
| $plainMetadata = $this->getAnnotationDriver()->loadMetadataForClass($refClass); | |||
| $doctrineMetadata = $this->getDoctrineDriver()->loadMetadataForClass($refClass); | |||
|
|
|||
| // Do not compare timestamps | |||
| $plainMetadata->createdAt = $doctrineMetadata->createdAt; | |||
There was a problem hiding this comment.
If this really is a problem, I'd prefer something that checks that the timestamps are equal within a few seconds, f.e. abs($timestamp1 - $timestamp2) < 5.
There was a problem hiding this comment.
Yep, I saw tests fail twice - on Travis and my own laptop. So it's worth fixing.
Do not compare "created" timestamps of class metadata as it may fail test on busy CPU
schmittjoh
added a commit
that referenced
this pull request
Sep 26, 2013
Fix DoctrineDriverTest random failures
|
Thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not compare "created" timestamps of class metadata as it may fail test on
busy CPU