Fix DateTimeZone issue when using the DateTime type #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrapped DateTimeZone object around the timezone when using the DateTime type.
schmittjoh
added a commit
that referenced
this pull request
Jan 20, 2013
Fix DateTimeZone issue when using the DateTime type
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, (unless I'm missing something), using the timezone parameter of the DateTime type does not work. It attempts to pass the timezone to the createFromFormat method as a string, rather than converting it to a DateTimeZone object first (as it does with the default timezone).
This PR simply wraps that line with a new \DateTimeZone call.