Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Update Symfony validator and allow PHPUnit 7 #583

Merged
merged 3 commits into from
May 9, 2016
Merged

Update Symfony validator and allow PHPUnit 7 #583

merged 3 commits into from
May 9, 2016

Conversation

goetas
Copy link
Collaborator

@goetas goetas commented May 9, 2016 •
edited
Loading

  • allow phpunit 5.0 and 4.0
  • allow sf validator ^2.2

@goetas goetas mentioned this pull request May 9, 2016
Merged
@goetas
Copy link
Collaborator Author

goetas commented May 9, 2016 •
edited
Loading

@stof i tired to allow the SF 3.0 validation api. ATM I suggest to postpone it since is not a trivial change.

The interface to use is Symfony\Component\Validator\Validator\ValidatorInterface right?

@goetas
Copy link
Collaborator Author

goetas commented May 9, 2016

@schmittjoh i guess the exception has been fixed, is it? still have to understand scrutinizer :)

@stof
Copy link
Contributor

stof commented May 9, 2016

@goetas right

@schmittjoh schmittjoh merged commit 67f4fe6 into schmittjoh:master May 9, 2016
@schmittjoh
Copy link
Owner

Guess I missed this pull-request :)

@goetas goetas deleted the validator-new branch May 14, 2016 09:34
@goetas goetas added this to the v1.2 milestone Aug 3, 2016
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.
3 participants
@goetas @stof @schmittjoh