Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Nullable array inconsistency #660

Merged
merged 4 commits into from
Oct 28, 2016
Merged

Nullable array inconsistency #660

merged 4 commits into from
Oct 28, 2016

Conversation

goetas
Copy link
Collaborator

@goetas goetas commented Oct 23, 2016

Fixes #593
Closes #626
Closes #36
Closes #642

Introduced with 8cb1e3c containing a non exact test case

The problem looks to be that the previous test case, having setSerializeNull(true), expects that:

array('foo' => 'bar', 'baz' => null, null)

is serialized into

// {"foo":"bar","baz":null}

instead of

// {"foo":"bar","baz":null,"0":null}

@hashnz do you remember the reason behind this test case?

@goetas
Copy link
Collaborator Author

goetas commented Oct 23, 2016

Similar to #626

@goetas goetas added this to the v1.4 milestone Oct 28, 2016
@goetas goetas merged commit 730ad5e into master Oct 28, 2016
@scaytrase
Copy link
Contributor

Hell yeah this one got fixed! Awaiting for the release

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants