Use the AnnotationReader interface in the SerializerBuilder, instead of the implemented AnnotationReader itself #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
schmittjoh
added a commit
that referenced
this pull request
Apr 22, 2013
Use the AnnotationReader interface in the SerializerBuilder, instead of the implemented AnnotationReader itself
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting the annotation reader to the SerializerBuilder, the reader must be an instance of the Doctrine\Common\Annotations\AnnotationReader class. This disallows the possibility of using other annotation readers, such as the CachedReader of Doctrine or a custom implementation. A better solution would be to use the interface which describes the Annotation Reader: Doctrine\Common\Annotations\Reader.
The set annotation reader is passed into the AnnotationDriver, which uses already this interface.