Skip to content

Upgrade Babel 7 #43

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Dec 14, 2018
Merged

Upgrade Babel 7 #43

merged 2 commits into from
Dec 14, 2018

Conversation

pioug
Copy link

@pioug pioug commented May 12, 2018

#42

  • Update package.json using npx babel-upgrade
  • Generate package lock with npm@6.0.1
  • Update unit tests.
    • Set compact: true when calling babel.transform to have consistent whitespace
    • Change quotes in "expected" code: It seems like Babel 7 generates code using double quote.

If you want formatting for compiled output you can use recast/prettier/escodegen/fork babel-generator. - http://new.babeljs.io/docs/en/next/v7-migration.html

The current babelify still depends on babel@6 though

@pioug pioug mentioned this pull request May 14, 2018
@vitaliusvs
Copy link

Are there any maintainers?

@schmod
Copy link
Owner

schmod commented Nov 26, 2018

Sorry, I've fallen behind on keeping this up to date. I'll try to take a look at open PRs this week!

@schmod schmod merged commit 7ff15db into schmod:master Dec 14, 2018
@pioug
Copy link
Author

pioug commented Jan 9, 2019

Hello @schmod! Thank you for reviewing the PR 👍 I saw you bumped the package version but the package has not been published on npm yet. Is there anything blocking the release? Maybe I can help if needed.

@schmod
Copy link
Owner

schmod commented Jan 10, 2019

No, that's totally my fault. I could have sworn I published it. facepalm

@schmod
Copy link
Owner

schmod commented Jan 10, 2019

published 0.10.0

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants