-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix broken file path in generated mapper file on Windows #174
Conversation
@schultek |
@realth000 did you see my comment above? Please test if this alternative also works. |
Sorry I still can't see the comment. Is it in this page or "Files Changed" tab or the issue page? |
packages/dart_mappable_builder/lib/src/builders/mappable_builder.dart
Outdated
Show resolved
Hide resolved
Oh totally my fault, I made the comment by still needed to "submit" the review 🤦♂️ |
Got it, I will check it tomorrow when I come back home. |
@schultek I tested Also worked without the config: |
Thanks |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #174 +/- ##
=======================================
Coverage 87.02% 87.02%
=======================================
Files 24 24
Lines 902 902
=======================================
Hits 785 785
Misses 117 117 ☔ View full report in Codecov by Sentry. |
Fixes #173
The
relative
method frompath
package does not offer an option to change the path separater so I replaced all\
with/
.I tried to run
flutter test
on my machine but meets this error:So... test with CI.
Update:
CI passed here