Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Measure test coverage #23

Merged
merged 2 commits into from
Aug 27, 2022
Merged

Conversation

jarrodmillman
Copy link
Member

@jarrodmillman jarrodmillman commented Aug 26, 2022

When using --doctest-modules , we get

=================================== FAILURES ===================================
____________________ test_attach_same_module_and_attr_name _____________________

    def test_attach_same_module_and_attr_name():
        from lazy_loader.tests import fake_pkg
    
        # Grab attribute twice, to ensure that importing it does not
        # override function by module
>       assert isinstance(fake_pkg.some_func, types.FunctionType)
E       AssertionError: assert False
E        +  where False = isinstance(<module 'lazy_loader.tests.fake_pkg.some_func' from '/home/runner/work/lazy_loader/lazy_loader/lazy_loader/tests/fake_pkg/some_func.py'>, <class 'function'>)
E        +    where <module 'lazy_loader.tests.fake_pkg.some_func' from '/home/runner/work/lazy_loader/lazy_loader/lazy_loader/tests/fake_pkg/some_func.py'> = <module 'lazy_loader.tests.fake_pkg' from '/home/runner/work/lazy_loader/lazy_loader/lazy_loader/tests/fake_pkg/__init__.py'>.some_func
E        +    and   <class 'function'> = types.FunctionType

lazy_loader/tests/test_lazy_loader.py:104: AssertionError

@jarrodmillman jarrodmillman force-pushed the coverage branch 2 times, most recently from e67f644 to 66eab5d Compare August 27, 2022 14:54
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@b08a4b9). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #23   +/-   ##
=======================================
  Coverage        ?   83.33%           
=======================================
  Files           ?        4           
  Lines           ?      174           
  Branches        ?        0           
=======================================
  Hits            ?      145           
  Misses          ?       29           
  Partials        ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jarrodmillman jarrodmillman merged commit eeb6a7d into scientific-python:main Aug 27, 2022
@jarrodmillman jarrodmillman deleted the coverage branch August 27, 2022 15:09
@jarrodmillman jarrodmillman added this to the 0.1 milestone Aug 29, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants