Correct stdout_write_bytes for UTF-8 chars. #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On branch master Your branch is up to date with 'origin/master'. Changes to be committed: modified: ampy/pyboard.py The original implementation of stdout_write_bytes() is writing the output byte by byte. This would break the multi-bytes UTF-8 char into mutiple single byte chars and cause problems with non ascii chars. I modify the implementation to output char by char according to the UTF-8 encoding.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On branch master
Your branch is up to date with 'origin/master'.
Changes to be committed:
modified: ampy/pyboard.py
The original implementation of stdout_write_bytes() is writing the output byte by byte. This would break the multi-bytes UTF-8 char into mutiple single byte chars and cause problems with non ascii chars.
I modify the implementation to output char by char according to the UTF-8 encoding.