Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: yields per region #189

Merged
merged 8 commits into from
Feb 5, 2021
Merged

feat: yields per region #189

merged 8 commits into from
Feb 5, 2021

Conversation

alexander-held
Copy link
Member

@alexander-held alexander-held commented Feb 1, 2021

Added tabulate._yields_per_channel to build yield tables with yields per channel. These tables are shown when visualize.data_MC is called with include_table=True (the default). model_utils.calculate_stdev is expanded to include calculation of uncertainties for the sum of yields per channel.

resolves #158

breaking changes:

  • model_utils.calculate_stdev now returns a tuple: uncertainties for all bins per channel, and uncertainties for total yield in channel
  • tabulate. _yields renamed to tabulate._yields_per_bin

@alexander-held alexander-held marked this pull request as draft February 1, 2021 18:26
@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #189 (f2e0746) into master (463aa45) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #189      +/-   ##
==========================================
+ Coverage   98.16%   98.19%   +0.02%     
==========================================
  Files          15       15              
  Lines        1639     1665      +26     
  Branches      256      265       +9     
==========================================
+ Hits         1609     1635      +26     
  Misses         28       28              
  Partials        2        2              
Impacted Files Coverage Δ
src/cabinetry/model_utils.py 100.00% <100.00%> (ø)
src/cabinetry/tabulate.py 100.00% <100.00%> (ø)
src/cabinetry/visualize.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 463aa45...f2e0746. Read the comment docs.

@alexander-held alexander-held marked this pull request as ready for review February 4, 2021 16:11
@alexander-held alexander-held mentioned this pull request Feb 4, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Yield tables
1 participant