Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: compatibility with matplotlib 3.4 #207

Merged
merged 2 commits into from
Mar 29, 2021

Conversation

alexander-held
Copy link
Member

@alexander-held alexander-held commented Mar 29, 2021

The recently released matplotlib version 3.4.0 produces very slightly different figures. This updates the reference figures for the corresponding test.

The update also revealed a warning for duplicate line style setting in two places, which was a harmless bug (the correct line style was picked up from the keyword argument already). This is also fixed here.

@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #207 (35ed34f) into master (076c529) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #207   +/-   ##
=======================================
  Coverage   98.25%   98.25%           
=======================================
  Files          15       15           
  Lines        1717     1717           
  Branches      267      267           
=======================================
  Hits         1687     1687           
  Misses         28       28           
  Partials        2        2           
Impacted Files Coverage Δ
src/cabinetry/contrib/matplotlib_visualize.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 076c529...35ed34f. Read the comment docs.

@alexander-held alexander-held merged commit d28f62c into master Mar 29, 2021
@alexander-held alexander-held deleted the fix/matplotlib-update-visualization branch March 29, 2021 15:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant