Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivated by scikit-hep/pyhf#1539, this switches from relative to absolute imports within
cabinetry
. Reasons are outlined in scikit-hep/pyhf#1539 (comment), reproduced below:The imports section of PEP 8 says
and
PEP 8 used to discourage relative imports more strongly.
The Google style guide section says
The relative imports used previously were originally motivated by
pyhf
, so it seems appropriate to switch to absolute imports together withpyhf
.