build: list direct dependencies explicitly #261
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Direct dependencies of
cabinetry
are now listed explicitly underinstall_requires
. These dependencies are already provided viapyhf
, and as such this change does not have an immediate effect. There are advantages to listing them explicitly anyway:pyhf
decided to drop one of the dependencies,cabinetry
would break, and this protects against that scenario,cabinetry
makes direct use of,pipdeptree
.The slightly more verbose
setup.cfg
seems like a negligible problem in comparison.This partially reverts #168.