Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

build: list direct dependencies explicitly #261

Merged
merged 2 commits into from
Aug 17, 2021

Conversation

alexander-held
Copy link
Member

Direct dependencies of cabinetry are now listed explicitly under install_requires. These dependencies are already provided via pyhf, and as such this change does not have an immediate effect. There are advantages to listing them explicitly anyway:

  • in case pyhf decided to drop one of the dependencies, cabinetry would break, and this protects against that scenario,
  • users can tell more easily which other libraries cabinetry makes direct use of,
  • the dependency tree is more correct, as visualized e.g. by pipdeptree.

The slightly more verbose setup.cfg seems like a negligible problem in comparison.

This partially reverts #168.

* explicitly require all direct dependencies of cabinetry via install_requires

@codecov
Copy link

codecov bot commented Aug 17, 2021

Codecov Report

Merging #261 (39ee9ea) into master (e565ec8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #261   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines         1742      1742           
  Branches       269       269           
=========================================
  Hits          1742      1742           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e565ec8...39ee9ea. Read the comment docs.

@alexander-held alexander-held merged commit 738f695 into master Aug 17, 2021
@alexander-held alexander-held deleted the build/explicit-dependencies branch August 17, 2021 14:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant