feat: restore optimizer settings after fits #362
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When performing fits via the
fit
API (e.g. MLEs orpyhf.infer.hypotest
viafit.limit
/fit.significance
), the optimizer is set to Minuit bycabinetry
viapyhf.set_backend
. Previously it just stayed this way, but now it instead gets set back to the initial settings (e.g. back toscipy
, which is thepyhf
default).Now that the second RC for
pyhf
0.7.0 is out, the integration test tolerance has to be slightly relaxed for CI to pass. Unclear why #361 is not affected by this. Locally a change in result bisects to scikit-hep/pyhf#1919, but the difference is so small that it likely is down to floating point differences amplifying in the post-fit yield uncertainty calculation.