Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: temporarily pin typeguard<3 #392

Merged
merged 3 commits into from
Mar 21, 2023
Merged

Conversation

alexander-held
Copy link
Member

@alexander-held alexander-held commented Mar 21, 2023

typeguard version 3.0 introduced CI failures in the nightly tests, see #391. Temporarily pin typeguard<3 to keep using the older version in CI. Eventually the newer version should be adopted in order to take advantage of the additional issues it can catch.

* temporarily pin typeguard<3 to fix CI
* updated pre-commit

@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c005bc2) 99.95% compared to head (925db01) 99.95%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #392   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files          23       23           
  Lines        2046     2046           
  Branches      324      324           
=======================================
  Hits         2045     2045           
  Misses          1        1           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alexander-held alexander-held force-pushed the fix/typeguard-pin-2.0 branch from a05debf to 925db01 Compare March 21, 2023 06:09
@alexander-held alexander-held merged commit ac28726 into master Mar 21, 2023
@alexander-held alexander-held deleted the fix/typeguard-pin-2.0 branch March 21, 2023 06:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant