Skip to content

Commit

Permalink
Remove test_step_sizes_fixed_parameters_minuit test
Browse files Browse the repository at this point in the history
As pyhf no longer controls step size, then don't attempt to test for it
  • Loading branch information
matthewfeickert committed Aug 9, 2022
1 parent 4c8787f commit db7a7d7
Showing 1 changed file with 0 additions and 16 deletions.
16 changes: 0 additions & 16 deletions tests/test_optim.py
Original file line number Diff line number Diff line change
Expand Up @@ -520,22 +520,6 @@ def test_init_pars_sync_fixed_values_minuit(mocker):
assert minimizer.fixed == [True, False, False]


def test_step_sizes_fixed_parameters_minuit(mocker):
opt = pyhf.optimize.minuit_optimizer()

# patch all we need
from pyhf.optimize import opt_minuit

minuit = mocker.patch.object(getattr(opt_minuit, 'iminuit'), 'Minuit')
minimizer = opt._get_minimizer(None, [9, 9, 9], [(0, 10)] * 3, fixed_vals=[(0, 1)])

assert minuit.called
assert minimizer.fixed == [True, False, False]
# iminuit v2.12.2+ sets non-zero step sizes for all parameters including fixed parameters
# c.f. https://github.com/scikit-hep/iminuit/issues/762
assert minimizer.errors == [0.01, 0.01, 0.01]


def test_solver_options_behavior_scipy(mocker):
opt = pyhf.optimize.scipy_optimizer(solver_options={'arbitrary_option': 'foobar'})

Expand Down

0 comments on commit db7a7d7

Please # to comment.