Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add a web-scraping script to determine, sort and filter dependent packages #4

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented Jul 29, 2020

This is the script used to make the table of bioimaging related packages in #3.

To run this script it is currently necessary to set a GITHUB_TOKEN environment variable to the user's GitHub API token

Additionally, it has the following python package requirements:

  • BeautifulSoup
  • Pandas
  • PyGithub
  • requests

It is intended that the user can change any options between the comment

# ----------------------------------
# START OF USER-CONFIGURABLE OPTIONS
# ----------------------------------

and the # END OF USER-CONFIGURABLE OPTIONS comment, but I did not create a command line interface for it at the moment.

includes filtering to those specific to biology/medicine
@pep8speaks
Copy link

pep8speaks commented Jul 29, 2020

Hello @grlee77! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-09-30 19:09:32 UTC

@jni
Copy link
Member

jni commented Jul 30, 2020

@grlee77 I haven't reviewed yet, but how is the output of this looking??? =D

@jni
Copy link
Member

jni commented Jul 30, 2020

scratch that, just found the issue! 😅 Great stuff.

Copy link
Member

@mkcor mkcor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this! 👍

skimage_filter_dependents.py Outdated Show resolved Hide resolved
skimage_filter_dependents.py Outdated Show resolved Hide resolved
skimage_filter_dependents.py Outdated Show resolved Hide resolved
skimage_filter_dependents.py Outdated Show resolved Hide resolved
skimage_filter_dependents.py Outdated Show resolved Hide resolved
skimage_filter_dependents.py Outdated Show resolved Hide resolved
skimage_filter_dependents.py Outdated Show resolved Hide resolved
Co-authored-by: Marianne Corvellec <marianne.corvellec@ens-lyon.org>
@grlee77
Copy link
Contributor Author

grlee77 commented Sep 30, 2020

Thanks @mkcor. I just tried out the "add suggestion to batch" option here for the first time. I'm not sure when that option first appeared, but it is a nice way to combine many related, minor suggestions into a single commit.

@mkcor
Copy link
Member

mkcor commented Sep 30, 2020

@grlee77 I'm glad! It's been around for a little bit; I haven't had a chance to use it very many times, but it's an elegant addition for sure. I guess this review with all these minor edits was the perfect use case!

Base automatically changed from master to main February 18, 2021 18:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants