Revert "Merge pull request #104 from ulupo/coo_format_patch" #112
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 07adc60.
The up-to-date version of upstream ripser which was integrated in the project by @MonkeyBreaker in #106 does not seem to suffer from the issues pointed out in #103 and addressed by #104.
It seems that there are no longer wrong outputs when sparse matrices are initialised in non-lexicographic ways. The unit test introduced by @ctralie in 1b565cf now serves as a regression test.
It would be nice to have @ubauer's or @MonkeyBreaker's confirmation that my reading of the situation is correct.