Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[CRITICAL] Pipenv-related improvements #387

Merged
merged 13 commits into from
Jun 17, 2020
Merged

[CRITICAL] Pipenv-related improvements #387

merged 13 commits into from
Jun 17, 2020

Conversation

frenzymadness
Copy link
Member

See the comments and the commit messages for better understanding of what I am trying to achieve.

Part one is for cases when a customer mirror contains also pipenv and has no internet access during a build. This is based on a request from a customer.

Part two is a better and testable solution for pipenv. We basically allow our customers to pin whatever version of pipenv works for them.

This was referenced Jun 9, 2020
Closed
Closed
Open
@frenzymadness frenzymadness force-pushed the pipenv_improvements branch 2 times, most recently from 53ba61b to 64384e1 Compare June 9, 2020 12:27
@frenzymadness frenzymadness marked this pull request as draft June 9, 2020 12:54
@frenzymadness
Copy link
Member Author

It seems that I also need to update our tests because logs are full of errors but the CI is green 😞

@frenzymadness frenzymadness force-pushed the pipenv_improvements branch from e88f613 to 08a5e28 Compare June 9, 2020 13:51
@frenzymadness
Copy link
Member Author

It seems to be working now. I'm gonna remove the last commit and all tests should pass.

@frenzymadness frenzymadness force-pushed the pipenv_improvements branch from 08a5e28 to eaf93d4 Compare June 9, 2020 19:40
@frenzymadness frenzymadness changed the title Pipenv-related improvements [CRITICAL] Pipenv-related improvements Jun 9, 2020
@frenzymadness
Copy link
Member Author

Marking this PR as critical because it also fixes our tests.

@frenzymadness
Copy link
Member Author

The problem with RHEL 8 is caused by incompatibility between micropipenv and pip 19.2.3. This should be fixed soon by either of these:

This PR is ready for a review @torsava

@frenzymadness frenzymadness marked this pull request as ready for review June 9, 2020 23:45
@hhorak
Copy link
Member

hhorak commented Jun 10, 2020

[test]

@frenzymadness
Copy link
Member Author

A new version of micropipenv is released which should make also rhel8 green. Will see. [test]

torsava
torsava approved these changes Jun 15, 2020
View reviewed changes
Copy link
Member

@torsava torsava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some suggestions to improved the docs and the comments.

Overall the changes look really good!

@frenzymadness
Copy link
Member Author

Thanks @torsava, I'm gonna squash your suggested changes and if the CI will be ok, I'll merge it.

frenzymadness and others added 12 commits June 16, 2020 08:31
@frenzymadness
Remove trailing whitespaces from README
d119d4b
@frenzymadness
Install tools like pipenv or micropipenv from a mirror first
4b40695 
If you have a mirror with Python packages with dependencies
of your application, the s2i-python-container will try to install
internal tools like pipenv from that mirror as well. If that try
fails, the second try will use --isolated and ignores pip settings.
@frenzymadness
Distgen regenerated content
bea9a38
@frenzymadness
Enable to use PIP_PIPENV_VERSION
852be0d
@frenzymadness
Distgen regenerated content
3c51ba9
@frenzymadness
Add a test for PIN_PIPENV_VERSION and Pipenv/requirements.txt combo
67e94f2
@frenzymadness
Distgen regenerated content
eca5d19
@frenzymadness
Check that the container app starts at all
d5b52b9
@frenzymadness
Distgen regenerated content
84216c6
@frenzymadness
Bugfix bad variable name
cfeb5c7
@frenzymadness
Distgen regenerated content
0f28eeb
@frenzymadness @torsava
Final docs/comments improvements by Tomáš
c68f671 
Co-authored-by: torsava <torsava@redhat.com>
@torsava
Copy link
Member

torsava commented Jun 16, 2020

Tests are failing on centos7 and fedora for some reason.

@frenzymadness
Copy link
Member Author

[test]

@frenzymadness
Copy link
Member Author

All green 🎉

@torsava
Copy link
Member

torsava commented Jun 16, 2020

Hm, I had to refresh 2 times before the new test results loaded.

Anyway, feel free to merge! :)

@frenzymadness frenzymadness merged commit 0620214 into master Jun 17, 2020
@frenzymadness frenzymadness deleted the pipenv_improvements branch April 30, 2021 06:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@torsava torsava torsava approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frenzymadness @hhorak @torsava